Ragnaroek / mithril

Pure Rust Monero Miner
GNU General Public License v3.0
231 stars 40 forks source link

Use of depricated function within a library #23

Closed Thanathotius closed 3 years ago

Thanathotius commented 4 years ago

Currently, mithril uses a depricated function which is the Select in:

use std::sync::mpsc::{channel, Sender, Receiver, RecvTimeoutError, Select};

error[E0432]: unresolved importstd::sync::mpsc::Select --> src\metric\mod.rs:3:68 | 3 | use std::sync::mpsc::{channel, Sender, Receiver, RecvTimeoutError, Select}; | ^^^^^^ noSelectinsync::mpsc

Is there a plan of when this is going to be redone? I imagine it's quite a lot of work to redo it but I still feel like it should be pointed out that the usage of this Select function is not in the library anymore.

Ragnaroek commented 4 years ago

Yes, Select was removed from Rust some time ago. There are plans to rework this, but not so soon. Also a update to the latest Monero version would be needed.

moriartydev commented 4 years ago

This error prevents me from building the project, any variants to solve it?

Ragnaroek commented 4 years ago

Currently the only way to build the project is to use an outdated rust version :(

Ragnaroek commented 3 years ago

replace the deprecated mpsc channel with crossbeam