RagnarokResearchLab / ragnarokresearchlab.github.io

Documentation that covers the technical aspects of Ragnarok Online
https://ragnarokresearchlab.github.io
14 stars 5 forks source link

Research ACT versions used in Arcturus and the alpha/beta clients #124

Open rdw-software opened 1 month ago

rdw-software commented 1 month ago

According to previous analysis results, the kRO client only contains ACT files using version 2.0 or higher:

https://raw.githubusercontent.com/RagnarokResearchLab/ragnarokresearchlab.github.io/986e690dd59f603dbed3d08f5c6046135a40531a/docs/file-formats/act-versions.png

This means the FFI decoder's version check for the animatione event ID would be pointless:

frame.animationEventID = (self.version >= 2.0) and reader:GetInt32() or -1

Source: RagnarokACT.lua

I don't remember why the version check is there. IIRC this was ported from the JS code directly, so there may be a reason for it. Or it could just a leftover from an incorrect third-party reference. Would have to check Arcturus and the alpha/beta clients.

I probably looked into this before and saved the results somewhere? Some day I might get around to looking into this again.

rdw-software commented 1 month ago

Not actionable until PAK support has been added properly (cleanup/tests needed): https://github.com/RagnarokResearchLab/RagLite/issues/353