search

Ragnarson-Internship2016 / group-I

0 stars 2 forks source link

Issue #19 - Add gem "Bootstrap" to application #42

Closed Kacper3331 closed 8 years ago

student-tomasz commented 8 years ago

Again, the same principle:

Does it add any functionality to the app? No. Does it fix an active bug? No. Does Bootstrap change any behavior of our in any way by itself? No.

All these changes should be a part of a larger PR with visible changes to views and stylesheets.

Kacper3331 commented 8 years ago

I still think it should be as a separate pull request, because it changes the look of our views in application but if we go with your thinking then this task should be done by Shadi not mine.

student-tomasz commented 8 years ago

No. It shouldn't be a part of a PR that revolves around adding a fundamental part of app's logic that is users' authentication.

Views in that PR are (or at least should be) only be generated, and not be touched any further. After his work is merged, and you want to change or add style to the views, then go to town. Adding bootstrap as a dependency then will be a great commit in a larger PR, but right now it's just nonsensical.

Mind you, I'm being really nit-picky here, but PRs such as this one, are really unnecessary and only bring more noise and busy-work than any real value.