search

Ragnyll / FridgeFiller

Our Project For CS 4096
1 stars 1 forks source link

Add items to pantry from shopping list #39

Closed jonsimington closed 8 years ago

jonsimington commented 8 years ago

ya boi is back at it again with another pull request.

This time, I implemented a form for the user to add an item from one of their shopping lists to their PERSONAL (not party-based, YET) pantry.

Item was added to pantry, button changed to edit in pantry, and success message is displayed so user knows something happened

Wow. I had way too much fun making this example list.

@brandonphelps @user404d @Ragnyll @Somsomguy Thoughts? Feel free to run git checkout new-list-button and play around with it!

user404d commented 8 years ago

Looks good to me, my dood.

On Tue, Mar 1, 2016 at 1:18 AM, Jon Simington notifications@github.com wrote:

ya boi is back at it with another pull request.

This time, I implemented a form for the user to add an item from one of their shopping lists to their PERSONAL (not party-based, YET) pantry.

-

UX: A form pops up on "add-to-pantry" button click and they fill out the info that they want. The only "required" field is the amount to add to the pantry, because it doesn't make sense (to me) to add zero of an item to a pantry. How could you have, or why would you want zero carrots in your pantry? At that point, it's dust, not carrots!

UI: See screenshots below. Only thing to mention is that once the user has successfully added an item from their list to their pantry, the button changes from "add to pantry" to "edit in pantry". The editing logic still needs to be done, but this is a good point to merge to master so we can get the production site updated.

Click "+ to Pantry" button, fill out the stuffs:

https://camo.githubusercontent.com/5ec76c193534cec63fd719afce047cbf460c3a3c/687474703a2f2f692e696d6775722e636f6d2f793947523876692e706e67 Item was added to pantry, button changed to edit in pantry, and success message is displayed so user knows something happened

~ http://i.imgur.com/ySBl3ly.png

Wow. I had way too much fun making this example list.

@brandonphelps https://github.com/brandonphelps @user404d https://github.com/user404d @Ragnyll https://github.com/Ragnyll @Somsomguy https://github.com/Somsomguy Thoughts? Feel free to run git

checkout new-list-button and play around with it!

You can view, comment on, or merge this pull request online at:

https://github.com/Ragnyll/FridgeFiller/pull/39 Commit Summary

  • Make name of new items title-cased and descriptions 1st letter cap.
  • Attach to list anchor when removing item and errors in adding
  • Implement the ability to add an item from your list to your PERSONAL pantry
  • Require pytz for timezone stuffs

File Changes

Patch Links:

— Reply to this email directly or view it on GitHub https://github.com/Ragnyll/FridgeFiller/pull/39.

jonsimington commented 8 years ago

Hearing no objections, I'm merging this in myself.