Ragnyll / FridgeFiller

Our Project For CS 4096
1 stars 1 forks source link

Quincydev #50

Closed user404d closed 8 years ago

jonsimington commented 8 years ago

Looks good. The only thing I'd suggest would be to add some sort of text inside the well, above the add item form to give some verbose feedback on success / error when looking up a barcode. Examples below:

Also, this should be added to the add item to pantry form, as well. Should be the same logic since the form takes name and description.

My dad mentioned it would be cool if the barcode scanning could somehow add price, amount and units when it scans.

Aaaaand last thing I noticed: I tried scanning on my phone, and it just brought up a black screen in my camera app. Perhaps mobile Chrome doesn't have permission to access the camera, or something. Also, on an iPhone, there is a menu that pops up after clicking the button that asks where I would like to upload the photo from (camera, photos, iCloud Drive, etc), so if we could make it just default to the system camera somehow, that'd be awesome.

Other than this long list of small things, it looks good, and functions fine when supplied with a valid barcode.

user404d commented 8 years ago

Bump

I think everything is good to go? Pull down and test away.