search

RagtagOpen / marchon-map

Map for March On https://www.wearemarchon.org
MIT License
5 stars 6 forks source link

Issue6: add filter by source to map #14

Closed marionnewlevant closed 6 years ago

marionnewlevant commented 6 years ago

This is for issue 6: add filter by source to map

This works, and I'm reasonably happy with it. It creates a Vue component to use as a mapbox control that shows and hides the layers

The main problem is that the list of layers is hard-coded into the component. There must be a way to pass them in, but I could only figure out 80% of that.

The other issue is that the show/hide widget could probably use some design love - what are the best ways to refer to these layers? Should the widget have a title? Duplicating the css probably wasn't ideal. Would be nice to show the little icons there in the widget.

But it's a good start.

Dec 29 - added some design love - little icons in the filter widget.

kielni commented 6 years ago

sorry, I merged the newer one first; can you rebase? I'll also add permissions for you on this repo so I can do the rebase next time I mess it up :)

marionnewlevant commented 6 years ago

@kielni: I moved the template into events.html (nice to know how to do that, thanks!). I am not happy with the names for the layers as they appear in the legend, but I don't know what the right names would be.