search

Rahix / avr-hal-template

cargo-generate template for avr-hal projects
Apache License 2.0
130 stars 28 forks source link

feat: add sparkfun-promini-v5 #25

Closed emilbonnek closed 10 months ago

emilbonnek commented 10 months ago

Following this pr I found there is no support for this in the cargo templating.

I have tried adding it here, but I am not totally sure its done correctly.

(closes #24)

emilbonnek commented 10 months ago

Sorry about those!

@Rahix Let me know if that did it.

Rahix commented 10 months ago

Nothing to be sorry about, code review cycles are a normal part of any open-source contribution ;)

Just for the future - you could have tested this yourself by running

cargo generate --git https://github.com/emilbonnek/avr-hal-template -b patch-1 --name sparkfun-promini-v5-test
cd sparkfun-promini-v5-test/
cargo build
emilbonnek commented 10 months ago

Nothing to be sorry about, code review cycles are a normal part of any open-source contribution ;)

Oh yeah, I know. I meant the spelling mistakes. I was on the phone when writing and I could have put in a little more effort so you wouldn't have to check these.

Looks good to me, at least I can compile the example program now.

👍Yay. Cheers! and thanks for making this project.