Open fernando-isensee opened 4 days ago
Hi, thanks a lot for the detailed report :) And thanks for testing the new ravedude config file code!
It would be best if you send your proposed fix as a pull-request, that makes it easier to discuss. In general, if you have code change suggestions, always open a pull-request for them.
Without having all the details in my head right now, some thoughts:
atmega1284p
is not a specific board so adding it as a "generic" target in Boards.toml
does not make much sense to me. Instead, this custom config should go entirely into your Ravedude.toml
, describing the particular setup of your project. The idea with the new config was that popular boards come pre-configured with ravedude but using ravedude for completely custom hardware works as well, using settings in the Ravedude.toml
file.Cc: @Creative0708
Hello, I would like to first apologize in advance if I am not raising this issue in a proper way, or if this is a nonissue and I am using the code incorrectly, or if it has been already fixed and will be released soon.
The Issue
I wanted to make a custom board based on atmega1284p to use with the libraries, but I was not able to program the device. The issue was that the
BoardAvrdudeOptions::baudrate
variable was not being overwritten by theserial_baudrate
[generic] settings I placed inRavedude.toml
.1) Add the following code to Boards.toml, with unspecified
baudrate
2) Setup the runner in my project's
config.rs
file:3) Setup the
Ravedude.toml
file with4) Result without the fix:
This happened because
baudrate
was being read from the fileBoards.toml
, which is-1
, so it ended up being converted toSome(Some(None))
.My proposed fix
1) I changed
main.rs
to from line169
to2) Result with the fix: