search

Rahix / shared-bus

Crate for sharing buses between multiple devices
Apache License 2.0
129 stars 34 forks source link

Xtensa lx6 #22

Closed pyaillet closed 3 years ago

pyaillet commented 3 years ago

Hi !

Thank you for this crate I'm using it with a shared i2c bus on an esp32.

Would you be interested in adding support for this kind of device ? If so, here is a PR.

I'm quite new to the Rust and embedded world so comments and suggestions are more than welcomed.

Rahix commented 3 years ago

Currently CI is still failing because the xtensa crate does not compile on stable rust. I'll have to take a look...

pyaillet commented 3 years ago

xtensa is not supported by official Rust and LLVM, to use it we must use a LLVM fork maintained by espressif, and a rust fork.

I can try to setup an action to handle this, but if the use of the fork is a no go for you, no problem.

Rahix commented 3 years ago

I can try to setup an action to handle this, but if the use of the fork is a no go for you, no problem.

I would rather not try to add this... Can you check whether a cargo +nightly build --all-features or a cargo +nightly check --all-features passes? If yes, I'd split the supported archs into "builds on stable" and "checks on nightly" groups and have two jobs for them.

pyaillet commented 3 years ago

Both seems to work fine: https://github.com/pyaillet/shared-bus/runs/3228754084?check_suite_focus=true

However I'm not sure to understand how you want to split this.

Rahix commented 3 years ago

Thanks. I'll take it from here, you don't need to worry about it :)