Closed Rahix closed 1 month ago
Attention: Patch coverage is 22.22222%
with 7 lines
in your changes missing coverage. Please review.
Project coverage is 62.26%. Comparing base (
d2c043f
) to head (1e14da5
).
Files | Patch % | Lines |
---|---|---|
tbot/machine/channel/subprocess.py | 22.22% | 7 Missing :warning: |
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
There were complaints that tbot would raise the "some subprocess(es) did not stop" error too quickly. The previous 1.27s timeout was too short for some programs to exit on their own.
To make tbot more graceful, increase the maximum termination time to 10.2 seconds. However, a warning will be emitted at 1.27s to let the user know why tbot is waiting.
Fixes: #116 Cc: @VictorEmelin