RaiMan / SikuliX-2014

SikuliX version 1.1.2 (until February 2018)
http://sikulix.com
806 stars 235 forks source link

Relax test-requirement for executables #222

Closed UnitedMarsupials-zz closed 8 years ago

UnitedMarsupials-zz commented 8 years ago

I had to do this, when porting v1.1.0 to FreeBSD. The older versions tested several other things -- including killall --version.

Well, killall exists on FreeBSD and even does the same thing as on Linux (unlike, say, on Solaris), but it does not have the --version option. It starts, but fails...

So it occurred to me, that it may be useful to distinguish failure to find the executable from the executable's own failure to run -- and to only "fail" it in the latter case.

UnitedMarsupials-zz commented 8 years ago

Err, sorry, the second commit is unrelated and was meant for a separate pull-request. Now you may as well review it here, I suppose...