search

Raid-Gaming / CoD4-Unleashed-Server

A custom CoD4 Dedicated Server mainly to improve the functionality and usability of the stock CoD4 Server.
https://raid-gaming.net/forum/18-call-of-duty-4-unleashed/
GNU Affero General Public License v3.0
9 stars 9 forks source link

Renamed a gsc function #16

Closed MichaelHillcox closed 7 years ago

MichaelHillcox commented 7 years ago

Logic bitch. Please use it.

Edit: now it's two functions!

atrX commented 7 years ago

Why rename httpPostRequest() to an ambiguous request()?

MichaelHillcox commented 7 years ago

Because DO IT! also just because its shorter and adding get request support would a one line if support kinda thing.

atrX commented 7 years ago

A name isn't better simply because it's shorter. Function names should be representative and unambiguous. httpPostRequest() was just fine.

I do agree with the other rename however.

MichaelHillcox commented 7 years ago

Fine. :P Although postRequest would be just fine.

atrX commented 7 years ago

Woops, didn't mean to approve.

MichaelHillcox commented 7 years ago

fixed