RaidcoreGG / Nexus

An Addon Host for Guild Wars 2. Handling loading & updating addons and provides a mod API.
https://raidcore.gg/Nexus
47 stars 5 forks source link

[Request] Import game keybinds #63

Open mistersister opened 1 month ago

mistersister commented 1 month ago

Since Nexus needs its separate keybindings I'm assuming the addon cannot read the game settings but if possible, it would be a pretty big QoL to be able to automatically import the existing game keybindings into Nexus.

DeltaGW2 commented 1 month ago

It's on the backlog, I'll try to finish it with the big UI update coming soon.

jsantorek commented 1 month ago

Also: GW2 stores its InputBinds in xml format like this one (also side note, InputBinds directory name seems to be affected by game's language), while nexus does so through json. Maybe it would be cool to keep here consistent with GW2, allowing import/export from/to people without nexus and/or using game client only?

DeltaGW2 commented 1 month ago

I don't understand the point of the request?

In what way should Nexus keep consistent with the game? The point of this issue is importing the binds via the XML, so what other import do you mean? What is there to export? The game already offers an export function? What do you mean by people without Nexus & game client only?

DeltaGW2 commented 1 month ago

Could you elaborate your request? @jsantorek

jsantorek commented 1 month ago

Hello friend, very sorry for the rambling and late reply - its been rough couple of days. Anyway, let me elaborate a bit.

  1. I've pointed out GW2 uses input bind serialization, has its own import/export methods - similarly to what nexus does
  2. Furthermore, files used for settings persistence are not compatible between these two contexts' (GW2 -> xml, Nexus -> json)

What I suggested, is to have nexus use the same format as GW2 already does - xml, example linked above. There is one, primary benefit to that, which is ability to share input bind files freely between players with and without Nexus.

DeltaGW2 commented 1 month ago

It would certainly be possible, the only issue with the format being the name field. Having to maintain another 4 lookup tables (6 if you consider Korean and Chinese) is not something I fancy in particular. I will confirm whether that field is optional and base my decision on that.

The reason Nexus has its own format to begin with is because I use Scan Codes, which admittedly ArenaNet uses too, but they hardcoded the US keyboard layout. Using the same hardcoded layout would mean lookup on load and lookup on save, which is tolerable I guess.