[Request/Bug] Move the RIO Side Frame when Premade-Groups-Filter is active

RaiderIO / raiderio-addon

RaiderIO AddOn

https://raider.io/addon

Other

40 stars 21 forks source link

[Request/Bug] Move the RIO Side Frame when Premade-Groups-Filter is active #187

Closed CDAGaming closed 2 years ago

CDAGaming commented 3 years ago

Made in reference to https://github.com/0xbs/premade-groups-filter/issues/61#issuecomment-902189575

CC: @0xbs

Vladinator commented 3 years ago

I pushed a commit in the feature branch with a lot of changes and improvements and adding PGF dialog check to it was quite simple. You can try it yourself by checking out that branch and see how it plays with the addon. All it would do is just anchor to the PGF frame instead of the Blizzard one and avoid the underlap situation. 78684f25933e16910670f46995f3619b4cd3c541

Also you can always contact us here with an issue, or on Discord directly, even a DM to me if you really wanted. I never tried to hide myself from being contacted. 🙁

Vladinator commented 2 years ago

I will create a feature branch to implement a more robust dynamic anchor system for the tooltip.

It will properly support PGF dynamic anchoring when the frame is shown to avoid this overlap.

Just commenting to update you on the situation.

Vladinator commented 2 years ago

The PR #191 will implement changes to tooltip anchoring. It's coming with 9.1.5 and is being tested until then, feel free to give it a spin as well.

I'm tagging you both @CDAGaming @0xbs since it's relevant to this issue #187 and the other issue in PGF's repo 0xbs/premade-groups-filter#61