Adding a hotfix for situations where ENCOUNTER_START is never called, but ENCOUNTER_STOP is...
This can be removed in 10.1.7 when it is fixed, but until then we will simply track that situation by setting ActiveEncounters to false instead of nil when such encounter occurs.
To clean-up we also wipe the table when PLAYER_ENTERING_WORLD occurs.
When the boss is defeated, we simply update the combatStart to equal the current timer, and bump the pulls counter.
Then alter when the boss UI updates we can detect this because delta will be 0 so in situations we are showing boss splits and the delta is 0 we just show the kill timer, and skip adding the split that would otherwise just show zero.
Added the RAID as type to raids, just to ensure that both dungeons and raids have a type property, that we can rely on to distinguish what a dungeon object represents.
Updated util:GetLFDStatusForCurrentActivity(activityID, includeExpansionDungeons) so it now has a boolean to include expansion dungeons, otherwise it will keep to seasonal dungeons, like expected everywhere this function is used. But we have the choice in the future if we ever need the dungeon extracted from the activity, regardless if it's seasonal or not.
Added new replay settings that lets the user specify a background color/opacity, and control the frame opacity as a whole.
You can preview the changes if the frame is visible, as changing the color or slider will adjust the frame visuals.
Made the tombstone icon (deaths counter) 1px smaller.
Vlad's changes:
Adding a hotfix for situations where ENCOUNTER_START is never called, but
ENCOUNTER_STOPis...This can be removed in 10.1.7 when it is fixed, but until then we will simply track that situation by setting
ActiveEncounterstofalseinstead ofnilwhen such encounter occurs.To clean-up we also wipe the table when
PLAYER_ENTERING_WORLDoccurs.When the boss is defeated, we simply update the
combatStartto equal the current timer, and bump thepullscounter.Then alter when the boss UI updates we can detect this because
deltawill be0so in situations we are showing boss splits and the delta is0we just show the kill timer, and skip adding the split that would otherwise just show zero.Added the RAID as type to raids, just to ensure that both dungeons and raids have a type property, that we can rely on to distinguish what a dungeon object represents.
Updated
util:GetLFDStatusForCurrentActivity(activityID, includeExpansionDungeons)so it now has a boolean to include expansion dungeons, otherwise it will keep to seasonal dungeons, like expected everywhere this function is used. But we have the choice in the future if we ever need the dungeon extracted from the activity, regardless if it's seasonal or not.Added new replay settings that lets the user specify a background color/opacity, and control the frame opacity as a whole.
You can preview the changes if the frame is visible, as changing the color or slider will adjust the frame visuals.
Made the tombstone icon (deaths counter) 1px smaller.