search

Raikia / FiercePhish

FiercePhish is a full-fledged phishing framework to manage all phishing engagements. It allows you to track separate phishing campaigns, schedule sending of emails, and much more.
https://github.com/Raikia/FiercePhish/wiki
GNU General Public License v3.0
1.31k stars 249 forks source link

UUID of target_users do not match the [uid] values embedded via the email template #24

Closed cobbr closed 7 years ago

cobbr commented 7 years ago

Is the [uid] value that gets placed into each email from the email template stored anywhere in the backend database? It doesn't appear to match the UUID value of the corresponding target_user.

It would be useful for tracking link clicks to be able to access this value externally from FiercePhish. I don't mind implementing this behavior myself, I just wanted to be sure that I'm not missing something.

Raikia commented 7 years ago

Right, so this is something that is already in the process of being fixed. The UUID of a user is not the same as the UUID sent in an email. It changes per campaign. So the UUID of the target user is not actually sent in an email, its used in combination with the campaign_id to generate a new UUID. Look at your campaign details and you will see the actual uuids sent and which user it corresponds to.

But yes, I am planning on changing how this is being saved for easier understanding.

Raikia commented 7 years ago

To answer your question: No, the uuid used in the email is not currently stored in the database. But that will change in the dev branch within the next 24-48 hours :-)

cobbr commented 7 years ago

Awesome! Thanks for the quick response. So, just to be clear, you are changing the behavior to use the target_user UUID in the email, or adding a UID field for emails in the database?

Raikia commented 7 years ago

There will be a UID field in the "emails" table. I think its important to have a different UUID for each user for each campaign (so the same user doesn't get the same UUID in later emails)

Raikia commented 7 years ago

The dev branch now has the UUID changes you requested. It will be merged in to master after testing.

cobbr commented 7 years ago

Thanks!

Raikia commented 7 years ago

Completed, committed, and merged into master.