search

Railgun-Community / private-proof-of-innocence

Node for Private Proof Of Innocence list provider and list aggregator.
MIT License
5 stars 6 forks source link

issue with circomlibjs dependancy still pointing to hsg88 repo #27

Closed dafrench57 closed 4 months ago

dafrench57 commented 4 months ago

trying to install POI node and getting issue with the circomlibjspackage. Tried to replace the circomlibjs hsg88 package by the railgun community package. As test I deleted also the api-test folder.

johndoe { ~/private-proof-of-innocence } # grep -r "circomlibjs" .
./packages/node/package.json:    "circomlibjs": "hsg88/circomlibjs#ffjavascrip.0.1.0",
./packages/node/yarn.lock:    circomlibjs hsg88/circomlibjs#ffjavascrip.0.1.0
./packages/node/yarn.lock:circomlibjs@hsg88/circomlibjs#ffjavascrip.0.1.0:
./packages/node/yarn.lock:  resolved "https://codeload.github.com/hsg88/circomlibjs/tar.gz/fee5b3c479caa3db1e34cbfdedad763d74277844"
./packages/node/src/poi-events/poi-merkletree.ts:import { poseidon } from 'circomlibjs';
./packages/node/src/types/index.d.ts:declare module 'circomlibjs' {
./packages/api-test/yarn.lock:    circomlibjs hsg88/circomlibjs#ffjavascrip.0.1.0
./packages/api-test/yarn.lock:circomlibjs@hsg88/circomlibjs#ffjavascrip.0.1.0:
./packages/api-test/yarn.lock:  resolved "https://codeload.github.com/hsg88/circomlibjs/tar.gz/fee5b3c479caa3db1e34cbfdedad763d74277844"
./packages/api-test/src/types/index.d.ts:declare module 'circomlibjs' {

johndoe { ~/private-proof-of-innocence } # grep -r "circomlibjs" .
./packages/node/package.json:    "@railgun-community/circomlibjs": "^0.0.8",
./packages/node/src/poi-events/poi-merkletree.ts:import { poseidon } from 'circomlibjs';
./packages/node/src/types/index.d.ts:declare module 'circomlibjs' {

johndoe { ~/private-proof-of-innocence-main/packages/node } # yarn install
yarn install v1.22.19
info No lockfile found.
[1/5] Validating package.json...
[2/5] Resolving packages...
warning @railgun-community/circomlibjs > web3 > web3-bzz > swarm-js > mkdirp-promise@5.0.1: This package is broken and no longer maintained. 'mkdirp' itself supports promises now, please switch to that.
warning @railgun-community/circomlibjs > web3 > web3-eth > web3-eth-ens > content-hash > cids@0.7.5: This module has been superseded by the multiformats module
warning @railgun-community/circomlibjs > web3 > web3-eth > web3-eth-ens > content-hash > multicodec@0.5.7: This module has been superseded by the multiformats module
warning @railgun-community/circomlibjs > web3 > web3-eth > web3-eth-ens > content-hash > cids > multicodec@1.0.4: This module has been superseded by the multiformats module
warning @railgun-community/circomlibjs > web3 > web3-bzz > swarm-js > eth-lib > servify > request@2.88.2: request has been deprecated, see https://github.com/request/request/issues/3142
warning @railgun-community/circomlibjs > web3 > web3-bzz > swarm-js > eth-lib > servify > request > uuid@3.4.0: Please upgrade  to version 7 or higher.  Older versions may use Math.random() in certain circumstances, which is known to be problematic.  See https://v8.dev/blog/math-random for details.
warning @railgun-community/circomlibjs > web3 > web3-eth > web3-eth-ens > content-hash > cids > multibase@0.6.1: This module has been superseded by the multiformats module
warning @railgun-community/circomlibjs > web3 > web3-eth > web3-eth-ens > content-hash > multihashes > multibase@0.7.0: This module has been superseded by the multiformats module
warning @railgun-community/circomlibjs > web3 > web3-bzz > swarm-js > eth-lib > servify > request > har-validator@5.1.5: this library is no longer supported
error Command failed.
Exit code: 128
Command: git
Arguments: ls-remote --tags --heads ssh://git@github.com/hsg88/circomlibjs.git
Directory: /root/private-proof-of-innocence-main/packages/node
Output:
ERROR: Repository not found.
fatal: Could not read from remote repository.

Please make sure you have the correct access rights
and the repository exists.

how can I solve this ?

jacobmakarsky commented 4 months ago

yarn why circomlibjs tells us "@railgun-community#wallet#@railgun-community#engine" depends on the deleted repository as well.

Adding a resolution to the node/package.json will force those nested dependencies to use the newer package. 

  "resolutions": {
    "circomlibjs": "git+https://github.com/railgun-community/circomlibjs.git"
  }

Note: The test suite uses Ethereum_Goerli, which is not online anymore so related tests will fail. An update is coming that uses Sepolia and deprecates The Graph for Subsquid.