search

Rails-18xx / Rails

Rails 18xx Java Application Main Repository
GNU General Public License v2.0
36 stars 22 forks source link

Freeze at tile laying step of operating round(1830) #513

Open alexsaintgill opened 1 year ago

alexsaintgill commented 1 year ago

Hi,

Thanks for your hard work in creating this wonderful program.

I have run this program twice so far for 1830, it is so amazing to help the game play.

However, I experience the program became idle in both trials that even since a 5-trains is bought and a brown tile is laid, the game stopped at the following operating round(5th operating round, in both cases).

When that happened I saw a railroad company was activated for its turn to lay down a track tile, but none of map tiles were reacting for a new or update tile. Skip was also not available, therefore, I got stuck at that moment.

Hopefully, this issue can be fixed so this wonderful program become 'more' towards flawless.

Thanks

erik-vos commented 1 year ago

Hi Alex, Do you have a saved file that shows the problem?

alexsaintgill commented 1 year ago

Hi,

Thanks for your prompt reply.

I am at work right now. Once back home, I will send you the saved file.

Thank you

On Friday, January 6, 2023, erik-vos @.***> wrote:

Hi Alex, Do you gave a saved file that shows the problem?

— Reply to this email directly, view it on GitHub https://github.com/Rails-18xx/Rails/issues/513#issuecomment-1373815679, or unsubscribe https://github.com/notifications/unsubscribe-auth/A5DNRSUWX4ATZEO3N24S34DWRA4PNANCNFSM6AAAAAATS2PBK4 . You are receiving this because you authored the thread.Message ID: @.***>

alexsaintgill commented 1 year ago

Hi,

Here I attached a saved file. It happened in two games in a row, but I did not save the second one. Also, I noticed when I load a saved file, the loading popup always stops at 92% and would not proceed. It just stays on the screen all the time.

Thanks

On Fri, Jan 6, 2023 at 8:58 AM Alex golsero @.***> wrote:

Hi,

Thanks for your prompt reply.

I am at work right now. Once back home, I will send you the saved file.

Thank you

On Friday, January 6, 2023, erik-vos @.***> wrote:

Hi Alex, Do you gave a saved file that shows the problem?

— Reply to this email directly, view it on GitHub https://github.com/Rails-18xx/Rails/issues/513#issuecomment-1373815679, or unsubscribe https://github.com/notifications/unsubscribe-auth/A5DNRSUWX4ATZEO3N24S34DWRA4PNANCNFSM6AAAAAATS2PBK4 . You are receiving this because you authored the thread.Message ID: @.***>

erik-vos commented 1 year ago

The saved file does not show up. GitHub accepts only a limited set of file types. I would suggest to put it into a .zip file.

alexsaintgill commented 1 year ago

I put it into a .zip file.

On Fri, Jan 6, 2023 at 4:48 PM erik-vos @.***> wrote:

The saved file does not show up. GitHub accepts only a limited set of file types. I would suggest to put it into a .zip file.

— Reply to this email directly, view it on GitHub https://github.com/Rails-18xx/Rails/issues/513#issuecomment-1374269570, or unsubscribe https://github.com/notifications/unsubscribe-auth/A5DNRSUXKYII6K77Q6MPTKDWRCVLTANCNFSM6AAAAAATS2PBK4 . You are receiving this because you authored the thread.Message ID: @.***>

erik-vos commented 1 year ago

Strange, the file still does not appear. Not sure what could go wrong. Could you please send it by email to ***@***?

What you are seeing must be caused by a run-time error somewhere. I tried to reproduce it with one of my old saved files, but did not see anything going wrong, either with the latest release 2.5.0 or with my newer development code. Which Rails version are you using?

erik-vos commented 1 year ago

Got the file now, thanks.

There seems to be a problem with handling the upgrades of multi-city tiles, in this case the brown Erie home tile. I suspect an error has crept in while fixing a similar problem in 1837. This is hard stuff, so it may take a bit of time.

erik-vos commented 1 year ago

It turns out that the brown tile lay on hex E11 (the Erie home hex) was illegal. The preceding tile 59 had exits to NW and SW for its two cities, but the new tile 64 now connects these two edges from one city. This has confused the program's housekeeping of stops and connections such that a run-time error occurred.

Of course, Rails should not have allowed this tile orientation, and in the past it worked fine, so there is a real bug behind this issue.

I have mailed Alex a slightly shortened game file, up to just before the error, to continue the game from there if he wants so.

alexsaintgill commented 1 year ago

Hi,

Thanks for your time and effort to fix this issue.

I ran the program again without violating the tile placement rules and successfully finished one full game.

You made such a great program that helps and enhances the play of 18xx series significantly.

Thanks again

On Tuesday, January 10, 2023, erik-vos @.***> wrote:

It turns out that the brown tile lay on hex E11 (the Erie home hex) was illegal. The preceding tile 59 had exits to NW and SW for its two cities, but the new tile 64 now connects these two edges from one city. This has confused the program's housekeeping of stops and connections such that a run-time error occurred.

Of course, Rails should not have allowed this tile orientation, and in the past it worked fine, so there is a real bug behind this issue.

I have mailed Alex a slightly shortened game file, up to just before the error, to continue the game from there if he wants so.

— Reply to this email directly, view it on GitHub https://github.com/Rails-18xx/Rails/issues/513#issuecomment-1377431033, or unsubscribe https://github.com/notifications/unsubscribe-auth/A5DNRSSMWJZLB2GXSVB5ZCTWRV4VZANCNFSM6AAAAAATS2PBK4 . You are receiving this because you authored the thread.Message ID: @.***>