erik-vos
commented
1 year ago The Ubuntu installer check fails on this PR. Looking back into Slack, I notice that this has happened several times since 13 dec 2022 with PRs from dependabot. In some cases the problem seems to have been fixed by (automatically?) deleting something. Can someone please sort out what is going on, and perhaps fix it?
During replaying a real 1826 game a lot of bugs and missing details have been detected and fixed. A problem remains with the calculation of H-train revenues, in particular 10H-trains, where sometimes cities are bypassed; see issue #520 and the 1826 game notes.
Further 18VA details have been added, in particular the various off-map bonuses. Special code had to be written to correctly handle 'minor' cities. The 'minor' attribute, which ever was only intended to facilitate n+m-trains, is now also used to determine which stops should be ignored with certain trains, and that is a matter of all or nothing. But in 18VA passenger trains ignore mines (represented by towns), but honour ports, although neither count against train length. I have been trying to refine the specification of such things, but that will affect the revenue calculation code with which I am not familiar.