Rails-18xx / Rails

Rails 18xx Java Application Main Repository
GNU General Public License v2.0
36 stars 22 forks source link

JavaFX #60

Open madoar opened 5 years ago

madoar commented 5 years ago

Just a little brainstorming on my side: I believe it would be useful to change the GUI implementation to JavaFX. In my opinion JavaFX has multiple advantages:

What do you think?

blentz commented 5 years ago

I'm not opposed to the idea of updating the UI.

If you want to create some pull-requests to help show your ideas, go ahead.

jklap commented 4 years ago

@madoar the current FXStockChartWindow implementation is acting as a singleton and starting a JavaFX Application. Can you please revisit this? My understanding is that you can mix JavaFX and Swing components together-- do we need to create this Application?

If we do then it should be independent of the FXStockChartWindow class.

Can you please either:

I realize that you originally wrote this as a POC to show as an example idea but given this is now becoming the main-line branch think this code needs to be cleaned up to make it production ready

madoar commented 4 years ago

It should be possible to integrate a JavaFX component in a Swing JFrame. To do this we would need to make use of a JFXPanel. For more details see here and here.

I'm currently not sure when I will have the time to work on this. It may take a while.

erik-vos commented 3 years ago

See also issue #297. JavaFX is not for me.

neutronc commented 3 years ago

grafik

neutronc commented 3 years ago

Is that what you wanted Erik ?

erik-vos commented 3 years ago

Yes, that is great.