Open madoar opened 5 years ago
I'm not opposed to the idea of updating the UI.
If you want to create some pull-requests to help show your ideas, go ahead.
@madoar the current FXStockChartWindow
implementation is acting as a singleton and starting a JavaFX Application
. Can you please revisit this? My understanding is that you can mix JavaFX and Swing components together-- do we need to create this Application
?
If we do then it should be independent of the FXStockChartWindow
class.
Can you please either:
Application
if that is possible (suspect not but thought I'd ask) orApplication
is independent and separate from the actual FXStockChartWindow
implementationI realize that you originally wrote this as a POC to show as an example idea but given this is now becoming the main-line branch think this code needs to be cleaned up to make it production ready
See also issue #297. JavaFX is not for me.
Is that what you wanted Erik ?
Yes, that is great.
Just a little brainstorming on my side: I believe it would be useful to change the GUI implementation to JavaFX. In my opinion JavaFX has multiple advantages:
What do you think?