RailsApps / learn-rails

An example Rails 5.1 app to accompany the "Learn Ruby on Rails" book.
https://learn-rails.com/install-rails-mac/index.html
392 stars 266 forks source link

Chapter 17 confusion #94

Closed ghost closed 7 years ago

ghost commented 7 years ago

Archive.zip

Chapter 17 test.

Only the "Home" bar changes and shows it is part of bootstprap. Went back over the changed files and could not see any. Restarted the server. Went ahead and copy and pasted and file from PDDF to config files. Restarted the server, still no change. While all of this was going on. I noticed the app/assets/javascript.js file did not have the modification of adding the entry "//= require bootstrap-sprockets" to the file after the "rails generate layout:install bootstrap3 --force" command was run. I added it in, saved the, restarted the server. no difference.

ghost commented 7 years ago

ALSO... macbook-pro:learn-rails bradhutchins$ rails -v Rails 5.0.2 macbook-pro:learn-rails bradhutchins$ ruby -v ruby 2.4.1p111 (2017-03-22 revision 58053) [x86_64-darwin16] macbook-pro:learn-rails bradhutchins$

DanielKehoe commented 7 years ago

I've made recent changes to the rails_layout gem to accommodate Rails 5.1. The changes introduced a bug that dropped the necessary jQuery support. Try again with the latest version of the rails_layout gem.

ghost commented 7 years ago

Sure.

What is the most recent rails_layout_gem file? Is it in an updated PDF of your book?

Sorry to be a pain.

On May 10, 2017, at 11:15 AM, Daniel Kehoe notifications@github.com wrote:

I've made recent changes to the rails_layout gem to accommodate Rails 5.1. The changes introduced a bug that dropped the necessary jQuery support. Try again with the latest version of the rails_layout gem.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/RailsApps/learn-rails/issues/94#issuecomment-300514979, or mute the thread https://github.com/notifications/unsubscribe-auth/AAIolpX3VUEFCYQwojhzGduj2fklcIjIks5r4dR9gaJpZM4NVelR.

ghost commented 7 years ago

Ok got the rails_layout gem 1.0.40 and changed Gemfile and Gemfile.lock but nothing is changing in presentation from before.

DanielKehoe commented 7 years ago

Closing this issue. Apparently resulting from confusion about what the application should look like in Chapter 17.