search

RailsApps / rails-stripe-membership-saas

An example Rails 4.2 app with Stripe and the Payola gem for a membership or subscription site.
http://railsapps.github.io/rails-stripe-membership-saas
1.14k stars 232 forks source link

Failing specs #118

Open adamtao opened 9 years ago

adamtao commented 9 years ago

Thanks for compiling this starter app. The specs are mostly failing for me. It seems the last database migration removes the "name" column for users, but the user factory still has that field. Also, app/views/users/show.html.erb attempts to display the name attribute.

I know you've been working on updating this application for rails 4.2, so I apologize if I'm reporting something you already know about. I'd be glad to help resolve this issue if you can use an extra hand. I'd just need to understand the reasoning behind removing the name column. Maybe it should just be added back in. If not, the factory/specs/views likely need updating.

Thanks!

DanielKehoe commented 9 years ago

Thanks for offering to help with the tests. It'd be great if you can contribute tests. I haven't done any work on tests yet. Please fork and contribute small, granular changes that I can easily review.

The name column only served to illustrate how to add a field when using Devise in the simpler starter apps. It seems that a name column is not desirable for a membership app since it is just extra info that is unnecessary.

kathyonu commented 9 years ago

@adamtao : This note replaced with my next comment.

kathyonu commented 9 years ago

@adamtao : Please see PR Testsformaster #150 . I invite you to pull this branch into your working app, and take it for a spin. The four pending tests are related to Issue #116. I believe the problem I ran into is the same, in terms of not knowing how to get the stripe_token into the payola processings. I am asking everyone for help resolving the four pendings, thank you.