search

RailsApps / rails3-devise-rspec-cucumber

An example Rails 3.2 app with Devise and RSpec and Cucumber.
http://railsapps.github.io/
445 stars 144 forks source link

Cuc refactor, remove reminants of web_steps.rb in favor of simple features #18

Closed thecatwasnot closed 12 years ago

thecatwasnot commented 12 years ago

Hi, since web_steps.rb got removed from cucumber for a reason, I thought I'd take a little time to fix the example cucumber features. I've not changed any functionality, only reworked the names and definitions of the steps to produce more maintainable features. There are, of course, further changes that could be made, but I thought I'd submit as-is to see if this is something you guys are interested in.

DanielKehoe commented 12 years ago

Cole,

Looks great! But can you resubmit without the Gemfile and Gemfile.lock and .rvmrc files?

-- Daniel

DanielKehoe commented 12 years ago

Hi Cole,

Great work!

I'd like to accept the pull request but commit 1e2f1b5 (https://github.com/thecatwasnot/rails3-devise-rspec-cucumber/commit/1e2f1b54292a2e32b4f732c8562365a94888e868) has a Gemfile, Gemfile.lock and .rvmrc file included.

Can you drop those and resubmit?

thanks!

Daniel Kehoe daniel@danielkehoe.com

On Monday, December 12, 2011 at 4:02 PM, Cole wrote:

Hi, since web_steps.rb got removed from cucumber for a reason, I thought I'd take a little time to fix the example cucumber features. I've not changed any functionality, only reworked the names and definitions of the steps to produce more maintainable features. There are, of course, further changes that could be made, but I thought I'd submit as-is to see if this is something you guys are interested in.

You can merge this Pull Request by running:

git pull https://github.com/thecatwasnot/rails3-devise-rspec-cucumber cuc-refactor

Or you can view, comment on it, or merge it online at:

https://github.com/RailsApps/rails3-devise-rspec-cucumber/pull/18

-- Commit Summary --

  • Move all step defs to capybara and remove unused
  • Push sign up feature complexity to step defs
  • DRY user sign up steps with a method
  • Cleaup unused sign up stuff
  • Push sign out feature complexity into steps
  • cleaup after sign out feature
  • Push sign out feature complexity into step definitions
  • Cleanup steps after sign in feature refactor
  • Forced user edit details into step definitons
  • Push user show feature complexity into step definitions
  • Get rid of the last of web_steps.rb, huzzah
  • Orginize steps a little

-- File Changes --

A .rvmrc (52) M Gemfile (1) M Gemfile.lock (4) M features/step_definitions/user_steps.rb (164) M features/users/sign_in.feature (37) M features/users/sign_out.feature (10) M features/users/sign_up.feature (47) M features/users/user_edit.feature (12) M features/users/user_show.feature (6)

-- Patch Links --

https://github.com/RailsApps/rails3-devise-rspec-cucumber/pull/18.patch https://github.com/RailsApps/rails3-devise-rspec-cucumber/pull/18.diff

Reply to this email directly or view it on GitHub: https://github.com/RailsApps/rails3-devise-rspec-cucumber/pull/18

thecatwasnot commented 12 years ago

I ended up doing some sorta bad git juju to get the files out, ended up with a forced push, so if you've got a local copy, probably should drop and re-pull it, sorry :/

DanielKehoe commented 12 years ago

I looked at it all online at GitHub so nothing local.

Do you have a new pull request for me?

Daniel Kehoe daniel@danielkehoe.com

On Monday, December 12, 2011 at 4:56 PM, Cole wrote:

I ended up doing some sorta bad git juju to get the files out, ended up with a forced push, so if you've got a local copy, probably should drop and re-pull it, sorry :/

Reply to this email directly or view it on GitHub: https://github.com/RailsApps/rails3-devise-rspec-cucumber/pull/18#issuecomment-3113579

thecatwasnot commented 12 years ago

Nope, just updated this one. Should be good to go :)

DanielKehoe commented 12 years ago

Thanks for the contribution, Cole!

-- Daniel