search

RailsApps / rails3-devise-rspec-cucumber

An example Rails 3.2 app with Devise and RSpec and Cucumber.
http://railsapps.github.io/
444 stars 144 forks source link

devise 2.1.0 and _links.html.haml #33

Closed JimOser closed 12 years ago

JimOser commented 12 years ago

devise 2.1.0 wants to see:

rails3-devise-rspec-cucumber/app/views/devise/_links.html.haml

not:

rails3-devise-rspec-cucumber/app/views/devise/shared/_links.html.haml

Many things are failing including:

rake cucumber features/users/sign_up.feature

Proposed solution:

git mv app/views/devise/shared/_links.html.haml app/views/devise/_links.html.haml

DanielKehoe commented 12 years ago

Could you please verify this? To test, I've just built a new app with Devise 2.1.0 and run "rails generate devise:views" and I see the file app/views/devise/shared/_links.erb.

I know this is very confusing as the Devise changelog shows Devise 2.0.0 (released Jan 2012) "Move devise/shared/_links.erb to devise/_links.erb". However, in February, there was this commit: https://github.com/plataformatec/devise/commit/9bf718dd82c0ac4ac1fdfc8fdbd0fe589d9bd995 which apparently never got listed in the changelog and reverts the links partial to the "shared" folder.

I updated the example app when I saw the reversion. Just checked and the example app uses Devise 2.1.0 and has the "shared" folder and all Cucumber tests succeed.

Can you doublecheck and give me more details of how to reproduce the reported error?

JimOser commented 12 years ago

I did: rails new myapp -m https://github.com/RailsApps/rails3-application-templates/raw/master/rails3-devise-rspec-cucumber-template.rb -T

and then chose the haml option.

Is this file correct? https://raw.github.com/RailsApps/rails3-application-templates/master/files/devise-views-haml/app/views/devise/registrations/new.html.haml

It says = render "links"

Should it say = render :partial => "devise/shared/links"

DanielKehoe commented 12 years ago

Ah, that's it. Thanks for bringing this to my attention. I overlooked updating the Haml version of that file after Devise reverted to using "devise/shared/links". I've fixed the file. Try it again and let me know if everything works. Sorry you ran into this failure.