RailsApps / rails_apps_composer

A gem with recipes to create Rails application templates for Rails starter apps.
http://railsapps.github.io/rails_apps_composer/
1.42k stars 306 forks source link

Changed call to confirm! to a call to confirm in recipes/init.rb to fix the Devise confirmable module #357

Closed tomelam closed 6 years ago

tomelam commented 7 years ago

This should fix the issue https://github.com/RailsApps/rails-devise-roles/issues/11 ("create_admin_service.rb causes rake to fail because the confirm! method was removed from the Devise gem").

Please refer to the changelog in master of the Devise gem.

kevinelliott commented 6 years ago

This looks good to me. @DanielKehoe do you think we can merge this? This has affected every app I have generated for at least 10 months and would be a welcome addition!

DanielKehoe commented 6 years ago

@tomelam Thanks for fixing this! I've released an updated version of the rails_apps_composer gem. @kevinelliott thanks for reminding me. I'm sorry for the slow response.