search

RailsEventStore / ecommerce

Application with CQRS and Event Sourcing built on Rails and Rails Event Store
MIT License
425 stars 72 forks source link

Change VAT Rate code from integer to string #392

Closed marlena-b closed 2 months ago

marlena-b commented 2 months ago

Issue: https://github.com/RailsEventStore/ecommerce/issues/391

I updated the product creation code to accept the VAT rate code as a string, aligning it with how VAT rates are created. Additionally, I renamed the attribute in the product form to vat_rate_code to better reflect that it represents the VAT rate code, not the entire VAT rate.

netlify[bot] commented 2 months ago

Deploy Preview for ecommerce-events failed.

Name Link
Latest commit 00e9f45c935e4e6e1a0ac786dc13820650c0b03c
Latest deploy log https://app.netlify.com/sites/ecommerce-events/deploys/66d6c6bd6fc71100084c7970
andrzejkrzywda commented 2 months ago

Looks good to me, possible next step could be to make it a value object.