RailsEventStore / rails_event_store

A Ruby implementation of an Event Store based on Active Record
http://railseventstore.org
MIT License
1.4k stars 122 forks source link

Make browser history know about pagination #1742

Closed swistak35 closed 4 months ago

swistak35 commented 4 months ago

A few more design (as in: code) improvements could be made:

I have a thought that instead of decomposing the model/flags and passing down only subset of fields, it would be better in most cases to pass whole model/flags, and decompose only if we are really on the bottom of displaying something. For example, I needed to pass down much more data into displayPagination, because there was assumption, that only links are enough, but it isn't. To that point it would still be good to pass everything from current component.