Closed lilyball closed 9 years ago
JFI: I have run the test suite with this patch applied and it does not cause any (additional failures).
It would be nice to have a test for this fix / with this PR! (I have just created a PR / Makefile, which makes running the tests easy: https://github.com/Raimondi/delimitMate/pull/183).
I'm not familiar with how to handle the tests, and I am not particularly inclined to install runVimTests and VimTAP unless absolutely necessary.
No problem.
(although "installing runVimTests" would get done automatically from "make test").
Currently the delimitMate repo appears to be unmaintained anyway?!
Javascript behaviour:
Before:
var obj = {|}
After:
var obj = {
|}
Expected:
var obj = {
|
}
// or
var obj = {
|}
// after another line-break:
var obj = {
|}
+1 for this.
@mplorentz Have you tried the PR / patch? Would you like to add a test case for / to it?
FWIW: using hub is a great way to checkout pull requests etc.
Besides this, the repository appears to be unmaintained: https://github.com/Raimondi/delimitMate/issues/191
My issue was actually with how smartindent handles python files and not with the DelimitMate plugin. Sorry.
@blueyed I'm having the same problem and I manually added the changes from your PR but it did not seem to help?
@marlun It's not my PR and I am not using it myself. I am using my fork, which is not that different: https://github.com/blueyed/delimitMate/compare/Raimondi:38487bb...blueyed:877e3ee
So, if you're using my fork then you won't have this fix.
Thanks!
When indentation is controlled by
'smartindent'
, the expand_cr behavior doesn't end up producing the same results that you would get without delimitMate. The following behavior results instead:The expected behavior is to produce the following:
To that end, detect when indentation is controlled by
'smartindent'
and adjust the indentation of the close line to match.