search

Raimondi / delimitMate

Vim plugin, provides insert mode auto-completion for quotes, parens, brackets, etc.
http://www.vim.org/scripts/script.php?script_id=2754
1.98k stars 117 forks source link

Excluded unite filetype #196

Closed blueyed closed 9 years ago

Raimondi commented 9 years ago

I see the point on removing the call to s:option_init() for this, but why should delimitMate care about the unite filetype (which I'm guessing is from a plugin)? I guess there are other filetypes where people would want delimitMate disabled, but I think it should be up to them to set it in their vimrc.

blueyed commented 9 years ago

It's meant to provide good defaults.

It might be better though to also / instead skip setup for !&modifiable (but Unite's buffer is modifiable) or for &buftype=nofile.

blueyed commented 9 years ago

I see the point on removing the call to s:option_init() for this

Please feel free to cherry-pick this already then - or should I provide a separate PR for it for easier merging?

Raimondi commented 9 years ago

I'd rather leave up to the user the interaction with external plugins. I cherry picked the excluded_ft fix commit.

Thanks!