RainLoop / rainloop-webmail

Simple, modern & fast web-based email client
http://rainloop.net
MIT License
4.1k stars 890 forks source link

Support dynamic salt lengths in ISPConfig password driver #2150

Closed sguter90 closed 1 year ago

sguter90 commented 2 years ago

This fixes the "CouldNotSaveNewPassword" error when changing password via settings for mailboxes created/updated in newer ISPConfig versions.

Additionally:

This should fix: https://github.com/RainLoop/rainloop-webmail/issues/2072 https://github.com/RainLoop/rainloop-webmail/issues/1946

Should include all fixes according ISPConfig solved in some other way in: https://github.com/RainLoop/rainloop-webmail/pull/2095

This still doesn't add support for multi server environments: https://github.com/RainLoop/rainloop-webmail/issues/733

I implemented the code with a PHP language level of 7.0. Everything above is supported. Wasn't sure if there are any style rules but I did my best to match with the style used in other plugins.

I tested the code with a local environment and on production servers. The password salt detection is backwards compatible with old passwords using a fixed salt length. So this shouldn't have any side effects on existing installations.

lol-deb commented 2 years ago

Hello, I just wanted to confirm that the patch works for me. Debian Bullseye - ISPConfig 3.2.8p1 - Rainloop 1.16.0 It solved https://github.com/RainLoop/rainloop-webmail/issues/2072 Thank you.