search

RainbowCookie32 / rusty-psn

A GUI/CLI tool for downloading PS3 and PS4 game updates
MIT License
362 stars 16 forks source link

Keeps panicking with `entered unreachable code` because of `poll-promise` v0.2.0 #172

Closed feathecutie closed 1 year ago

feathecutie commented 1 year ago

I can't run rusty-psn without it panicking, and the issue seems to be related to poll-promise. The exact issue is

thread 'main' panicked at 'internal error: entered unreachable code', /build/rusty-psn-0.3.0-vendor.tar.gz/poll-promise/src/promise.rs:285:49

According to this issue, this seems to be caused by a fatal bug in poll-promise version 0.2.0 that is resolved in 0.3.0, which rusty-psn should update to if possible.

RainbowCookie32 commented 1 year ago

Thanks for the report and for tracking down the cause. I'll update all the dependencies in a bit and tag a new release

RainbowCookie32 commented 1 year ago

Pushed 233d80ce878e496bc35c4b1f794e811493071b22 with the updated dependencies. Everything seems to be working on my side, but please test once it's done building: https://github.com/RainbowCookie32/rusty-psn/actions/runs/6371439405

RainbowCookie32 commented 1 year ago

Tagged the new release. I'll close this assuming it's fixed now, but let me know if there's still an issue and I'll reopen.

feathecutie commented 1 year ago

Works perfectly now, thanks!

Sadly the update to poll-promise v0.3.0 comes with its own can of worms when trying to update the rusty-psn package for the Nix package manager because poll-promise started using the document-features crate which doesn't work well with vendored dependencies as Nix uses them, but this is something I'll have to look into further. It definitely doen't seem to be something that can be fixed on rusty-psn's side.

RainbowCookie32 commented 1 year ago

Sucks that something else broke with the fix. It's indeed not something I can fix on my side afaik, not without either forking poll-promise to nuke the dependency, or replacing poll-promise with something else. Both are a pain. I'll try to keep a closer eye on dependency updates at least, in case it gets magically fixed.

surfaceflinger commented 6 months ago

@RainbowCookie32 document-feature got fixed, opened an issue in poll-promise to tag a new release with bumped deps https://github.com/EmbarkStudios/poll-promise/issues/27