search

RainbowCookie32 / rusty-psn

A GUI/CLI tool for downloading PS3 and PS4 game updates
MIT License
362 stars 16 forks source link

Fix info fetching not showing errors #232

Closed sarpt closed 2 months ago

sarpt commented 2 months ago

I've noticed that on the current master when a serial is provided that does not have any updates or for some reason initial fetch for update information fails, no information about error is being provided no matter how long one waits for a result: image

I've checked out what might be the cause of this issue and seems that the part of code that waited for a promise to be ready by checking if promise is resolving to Some, it instead waited for promise resolving to Some and the result of it be Ok, which in case of errors promise resolved to Some, but the result of it was Err.

After changing that toasts about errors started appearing again: image

RainbowCookie32 commented 2 months ago

I noticed this one after working on #225 but I couldn't get around to looking into it. Turns out it was way simpler than I expected 😅

Thanks for looking into it and PR'ing a fix!