search

RainbowCookie32 / rusty-psn

A GUI/CLI tool for downloading PS3 and PS4 game updates
MIT License
379 stars 17 forks source link

Add option to disable file logs #237

Closed sarpt closed 3 months ago

sarpt commented 3 months ago

I'd like to suggest a small feature - I've noticed that the program with every process instance creates a new .log file and logs regular and debug output into it. I thought that it would be useful to have an option to disable this logging as to not produce a lot of files from multiple runs when they might not be necessary.

I've added a new flag to arguments -n, --no-file-log (not sure about that name though but I don't have a better idea for it...) that lets an user control log files writing behaviour - true to disable logging and false to keep logging. The default of creating log files stays as is. The option is available in both cli and egui versions, but since cli needs more arguments than egui does, their handled arguments differ:

As an effect of this change now both cli and egui releases are dependent on clap, instead of only cli, as the arguments handling has been generalized in main.rs.

RainbowCookie32 commented 3 months ago

Neat, will wait for CI then merge. Thanks for the contribution!