search

RainbowCookie32 / rusty-psn

A GUI/CLI tool for downloading PS3 and PS4 game updates
MIT License
362 stars 16 forks source link

Fix egui errors when downloading the same title id again #241

Closed sarpt closed 2 months ago

sarpt commented 2 months ago

After my previous PR https://github.com/RainbowCookie32/rusty-psn/pull/233 I've noticed that downloading information for the same title id with a dash more than once results in egui showing incorrect list with errors: image

I've failed to notice in the previous PR that duplication check uses serial ids from fetched packages, which never use dashes in title id, hence they would never match. I've separated the part of code that removes whitespaces and dashes and used it in both places. Additionally, a new prompt has been added in case a user searches for the duplicate title id to not confuse the user when nothing changes in the list: image

RainbowCookie32 commented 2 months ago

Good catch, thanks for the PR!

sarpt commented 2 months ago

Thank you. Seems like this change was approved instead of merged so the new release https://github.com/RainbowCookie32/rusty-psn/releases/tag/v0.4.6 refers to the previous PR instead of this one.

RainbowCookie32 commented 2 months ago

Well that explains why CI was instantly done lmao. Thanks for the heads-up