search

RainbowHackerHorse / vzvol

vzvol is a general use ZFS zvol management tool, that handles creation, destruction, listing, and formatting with various FSes, in an easy to use single program
BSD 2-Clause "Simplified" License
31 stars 5 forks source link

FreeBSD 11.1: bad check for presence of sudo #19

Closed adriaandegroot closed 6 years ago

adriaandegroot commented 6 years ago

Using pkg -N info | grep sudo to check for the presence of sudo is likely to hit false positives, e.g. with various sudoku programs installed. pkg -N info -e sudo is probably a better bet.

adriaandegroot commented 6 years ago

Similar checks are in freebsd/vzvol_pkgcheck.sh, although i expect fewer false positives with those, see e.g. https://www.freshports.org/search.php?query=e2fsprogs

RainbowHackerHorse commented 6 years ago

Good point. I'll be moving to check binary location directly on disk. This is already planned for the next patch.