RainbowMage / OverlayPlugin

Other
132 stars 182 forks source link

Added GUI for configuring MiniParse size #2

Closed Blazewardog closed 9 years ago

Blazewardog commented 9 years ago

Went and added options in the GUI for setting the size for MiniParse already found in the XML. Didn't add it for spell timer as I personally don't use those, but it should just be adding another event handler.

RainbowMage commented 9 years ago

For job icons: I can't merge these icons due to consideration of violating ファイナルファンタジーXIV 著作物利用許諾条件. Sadly we are currently not allowed to use FFXIV material on the third-party software. (Of course, we can use on our web site.)

For options of overlay size: Is this option really needed? You can change the overlay window size by simply dragging bottom-right corner of the window.

Thank you for your pull request.

Blazewardog commented 9 years ago

When I was initially messing with the plugin I didn't find this option (hence the patch). Someone else today pointed this out today so I'll cancel the pull when I get a chance. That said, the size changing wasn't obvious to me and one of my FC mates.

As far as the icons go, do you think it would go with the link you have if we did something like checking if the icons are present and using them and otherwise just use the abbreviations for each job? Then players could just download the icons themselves. Thus suitor be similar in approach as console emulators and the console bios images. On Dec 16, 2014 1:49 PM, "RainbowMage" notifications@github.com wrote:

For job icons: I can't merge these icons due to consideration of violating ファイナルファンタジーXIV 著作物利用許諾条件 http://support.jp.square-enix.com/rule.php?id=5381&la=0&tag=authc. Sadly we are currently not allowed to use FFXIV material on the third-party software. (Of course, we can use on our web site.)

For options of overlay size: Is this option really needed? You can change the overlay window size by simply dragging bottom-right corner of the window.

Thank you for your pull request.

— Reply to this email directly or view it on GitHub https://github.com/RainbowMage/OverlayPlugin/pull/2#issuecomment-67220097 .