Rainie3535 / sigil

Automatically exported from code.google.com/p/sigil
GNU General Public License v3.0
0 stars 0 forks source link

Search doesn't work for "all html files" #1145

Closed GoogleCodeExporter closed 9 years ago

GoogleCodeExporter commented 9 years ago
Please read http://code.google.com/p/sigil/wiki/ReportingIssues for
information about submitting a good bug report.

What steps will reproduce the problem?
1. Open an epub with several .html files, switch to WYSIWYG view.
2. Open search with ctrl+f, select 'normal' and 'all html files'
3. Search for a phrase that is known to exist in a file that isn't currently 
open.
...

What is the expected output? What do you see instead?
Sigil should find the text.  Instead it says "search term cannot be found."  If 
you open and select the file that contains the text and try to search again, 
the text is correctly found.

What version of the product are you using? On what operating system?
Sigil 0.4.902

Original issue reported on code.google.com by alexande...@gmail.com on 27 Dec 2011 at 7:12

GoogleCodeExporter commented 9 years ago
Forgot to mention this is on Ubuntu 11.04 64bit.

Original comment by alexande...@gmail.com on 27 Dec 2011 at 7:14

GoogleCodeExporter commented 9 years ago
book view does not, will not and cannot support multi-file searching.

Original comment by john@nachtimwald.com on 27 Dec 2011 at 11:43

GoogleCodeExporter commented 9 years ago
If it doesn't work then there shouldn't be an option to do such a search, like 
in the old Sigil search box.  Otherwise it's confusing and can lead people to 
believe their search text doesn't exist in the book if they're not familiar 
with this limitation.

Original comment by alexande...@gmail.com on 28 Dec 2011 at 12:13

GoogleCodeExporter commented 9 years ago
The old search box had this option as well. It was moved to become more 
visibile.

Original comment by john@nachtimwald.com on 28 Dec 2011 at 12:34

GoogleCodeExporter commented 9 years ago
Yeah but if you tried to search in wysiwig view with that option selected in 
the older version, it popped up an alert saying it wasn't possible to search 
that way.  In the new version it just says "no results found" which can be 
misleading, because maybe the result does exist, but the user isn't alerted to 
the fact that Sigil didn't really do an all-file search.

IMHO a good solution would be to force that combo box to "only this file" when 
in wysiwig view and not allow switching it to "all files" until view is 
switched to code view.  That way it's clear which files you're searching.

Original comment by alexande...@gmail.com on 28 Dec 2011 at 12:51

GoogleCodeExporter commented 9 years ago
Alert is back.

Original comment by john@nachtimwald.com on 28 Dec 2011 at 1:14

GoogleCodeExporter commented 9 years ago
Issue 1151 has been merged into this issue.

Original comment by john@nachtimwald.com on 1 Jan 2012 at 6:49