Rainie3535 / sigil

Automatically exported from code.google.com/p/sigil
GNU General Public License v3.0
0 stars 0 forks source link

F&R updates to add searching selected files and direction all/wrap, plus bug fixes #1225

Closed GoogleCodeExporter closed 9 years ago

GoogleCodeExporter commented 9 years ago

- Added Direction All to support searching down and wrapping around at the end 
of the file or book
- Added Look in Selected HTML Files to allow searching only the files selected 
in the Book Browser instead of all files.  Can only be used in Code View. 
- Added tooltips for drop down boxes and modified button tooltips
- Fixed bug in 0.5.0 that meant the first occurrence of a match would not be 
replaced if you were set All HTML Files and searched from teh end of the 
previous document.  Text would be highlighted okay, but selecting Replace would 
not replace it.
- Fixed behaviour where find in All Files would wrap around to start - now that 
there is a wrap, Up/Down should behave the same in file as in book
- Fixed Find button for direction all from previous patch

Original issue reported on code.google.com by meme90...@gmail.com on 2 Feb 2012 at 8:49

Attachments:

GoogleCodeExporter commented 9 years ago
Patch attached.

Original comment by meme90...@gmail.com on 2 Feb 2012 at 8:52

Attachments:

GoogleCodeExporter commented 9 years ago
Can you split the search in selection out into a separate patch. I want to 
evaluate it separately for a later release. I'm not sure about the usefulness.

Also, the check for CountInFiles > 0 before doing some type of search operation 
is not a good idea. Instead the current position in the current file should be 
marked, search through each file until a match is found. If a match is not 
found in any file search the top part of the current file. If there is no match 
take the appropriate action.

The CountInFiles call causes every file to be searched every time a search 
operation is performed. The above implantation will stop the search once the 
first match is found and if it's the current or next file will prevent all 
other files from being searched.

Original comment by john@nachtimwald.com on 3 Feb 2012 at 12:43

GoogleCodeExporter commented 9 years ago
Updated patch

- Removed wrap - so Up/Down now wrap in-file with a message that search wrapped 
around, and wrap in all files with no message
- fixed bug with text in the next file next being highlighted 
- Replace now automatically goes to code view instead of a message
- fixed 0.5.0 bug where in CV if you do a replace of a word and then replace 
all when there are the same words on the page, the page view wouldn't be 
refreshed
- added en translation for singular/plural matches/replacements
- Removed countinfiles check to prevent looping and replaced by marker check
- Selected HTML files still present for the moment

Original comment by meme90...@gmail.com on 3 Feb 2012 at 9:02

Attachments:

GoogleCodeExporter commented 9 years ago
Revision: abe47d469583.

Original comment by john@nachtimwald.com on 4 Feb 2012 at 5:02

GoogleCodeExporter commented 9 years ago
Additional patch to sort Selected Files to make sure Find is done in sequence.

Original comment by meme90...@gmail.com on 5 Feb 2012 at 9:28

Attachments:

GoogleCodeExporter commented 9 years ago

Original comment by meme90...@gmail.com on 28 Mar 2012 at 3:55

GoogleCodeExporter commented 9 years ago

Original comment by daveheil...@gmail.com on 19 May 2012 at 3:20