Closed GoogleCodeExporter closed 9 years ago
Patch attached.
Original comment by meme90...@gmail.com
on 2 Feb 2012 at 8:52
Attachments:
Can you split the search in selection out into a separate patch. I want to
evaluate it separately for a later release. I'm not sure about the usefulness.
Also, the check for CountInFiles > 0 before doing some type of search operation
is not a good idea. Instead the current position in the current file should be
marked, search through each file until a match is found. If a match is not
found in any file search the top part of the current file. If there is no match
take the appropriate action.
The CountInFiles call causes every file to be searched every time a search
operation is performed. The above implantation will stop the search once the
first match is found and if it's the current or next file will prevent all
other files from being searched.
Original comment by john@nachtimwald.com
on 3 Feb 2012 at 12:43
Updated patch
- Removed wrap - so Up/Down now wrap in-file with a message that search wrapped
around, and wrap in all files with no message
- fixed bug with text in the next file next being highlighted
- Replace now automatically goes to code view instead of a message
- fixed 0.5.0 bug where in CV if you do a replace of a word and then replace
all when there are the same words on the page, the page view wouldn't be
refreshed
- added en translation for singular/plural matches/replacements
- Removed countinfiles check to prevent looping and replaced by marker check
- Selected HTML files still present for the moment
Original comment by meme90...@gmail.com
on 3 Feb 2012 at 9:02
Attachments:
Revision: abe47d469583.
Original comment by john@nachtimwald.com
on 4 Feb 2012 at 5:02
Additional patch to sort Selected Files to make sure Find is done in sequence.
Original comment by meme90...@gmail.com
on 5 Feb 2012 at 9:28
Attachments:
Original comment by meme90...@gmail.com
on 28 Mar 2012 at 3:55
Original comment by daveheil...@gmail.com
on 19 May 2012 at 3:20
Original issue reported on code.google.com by
meme90...@gmail.com
on 2 Feb 2012 at 8:49Attachments: