search

Rainie3535 / sigil

Automatically exported from code.google.com/p/sigil
GNU General Public License v3.0
0 stars 0 forks source link

Display image properties #1285

Closed GoogleCodeExporter closed 9 years ago

GoogleCodeExporter commented 9 years ago 
When selecting an image in the Book view, or when opening it in a tab by 
double-clicking on its name in the Book browser, it would be very nice to see 
its properties in the status bar (size in pixels and weigth in Ko)

Original issue reported on code.google.com by nicolas....@gmail.com on 23 Feb 2012 at 12:31

GoogleCodeExporter commented 9 years ago

Original comment by meme90...@gmail.com on 5 Mar 2012 at 5:11

GoogleCodeExporter commented 9 years ago 
Patch attached:

- Add image properties to image tab status bar
- Properties include widthxheight, size in KB, color/grayscale, number of times 
the image is used in the book
- Adds property information and small image to Insert Image dialog
- Adds View Image Details to menu to show image information
- Saves window/column sizes for Image dialog

Original comment by meme90...@gmail.com on 16 Mar 2012 at 5:43

Attachments:

GoogleCodeExporter commented 9 years ago 
New patch attached, using threads, adding filtering, and merged with latest 
source.

Original comment by meme90...@gmail.com on 23 Mar 2012 at 5:23

Attachments:

GoogleCodeExporter commented 9 years ago 
A couple of things that need to be changed for this.

We shouldn't have multiple labels in the status bar for tab info. Right now 
there is a cursor position label and a now an image info label. We should have 
one general tab info label and allow the tab to display it's own info here. 
Basically the MainWindow should query for tab specific information and put 
whatever text is returned in a tab info label in the status bar. This way the 
MainWindow doesn't need to know specific about the type of info nor does it 
need multiple labels for each type of info that's just a text string.

The Insert Image dialog needs to be reworked because you can only open it when 
a flow tab is in use. A user might want to just get general info about the 
image when editing the OPF.

In the Insert Image dialog there is a column for color. This is unnecessary. If 
the image is in color you can tell by looking at the thumbnail. That and it's 
not a very useful piece informatton.

The Insert Image dialog should have the columns sized to the contents instead 
of being the same size. I also see no need to store the column widths if they 
are sized according to the data in them.

The Insert Image dialog starts upon first opening with the preview squashed to 
a few pixels wide. The user shouldn't be forced to resize anything to have the 
dialog useable. They should only have to resize to make it more comfortable for 
their preference.

It might be better to have a separate image info dialog instead of putting it 
into the Insert Image dialog. This way images can have a right click option in 
the book browser to see it's info. The Insert Image dialog could also be able 
to open this dialog if the user wants to see additional information when 
deciding which image to insert. This would probably be a better way to go as 
it's more flexible and would negate most of the issues with the changes to the 
Insert Image dialog.

BookManipulation/Book.cpp has boost tuples includes added but I don't see where 
they're being used. Boost should be avoided when possible.

In BookManipulation/Book.cpp you've added a fixed path to the image directoroy:
static const QString IMAGES_DIR       = "../Images/";
Restructing to place all images in the ../Images directory will be removed in 
the future so this should not be dependent on a fixed location.

Original comment by john@nachtimwald.com on 24 Mar 2012 at 3:06

GoogleCodeExporter commented 9 years ago 
New patch updated addressing the issues above.  And issue 1325.

Original comment by meme90...@gmail.com on 26 Mar 2012 at 6:30

Attachments:

GoogleCodeExporter commented 9 years ago 
Updated patch to merge with latest source.

Separated insert and view into separate dialogs for clarity/flexibility.

Original comment by meme90...@gmail.com on 24 Apr 2012 at 6:48

Attachments:

GoogleCodeExporter commented 9 years ago 
Image properties will display under the image when opening the image resource.

Original comment by john@nachtimwald.com on 4 May 2012 at 1:11

GoogleCodeExporter commented 9 years ago

Original comment by daveheil...@gmail.com on 19 May 2012 at 3:20