search

Rainie3535 / sigil

Automatically exported from code.google.com/p/sigil
GNU General Public License v3.0
0 stars 0 forks source link

Sigil fonts should be configurable in Preferences #985

Closed GoogleCodeExporter closed 9 years ago

GoogleCodeExporter commented 9 years ago 
What steps will reproduce the problem?
1.  Open epub
2.  System fonts appear in Book Browser, Table of Contents, Menus, and 
Validation results
3.  Book View, tab titles, and labels all appear to be in Arial or something 
similar (a sans-serif font)
...

What is the expected output? What do you see instead?

I expect all text and labels I see to be in system fonts (or to allow me to 
choose a default display font in options somewhere), unless there is a reason 
to use a different font, such as in Code View.

I have changed all of my Windows system fonts to use serif fonts.  I therefore 
expect to see the text in the Book View to be in a serif font.  It appears in a 
sans-serif font.  I do not know where this font is coming from (no font is 
specified in the epub's css) and there is no program option to change it.  

What version of the product are you using? On what operating system?
Sigil 0.4.0, Windows 7.

Please provide any additional information below. If your source file
(SGF/EPUB/HTML/etc) is required to fully understand the problem, please
attach it to this issue. Read the ReportingIssues wiki page before
submitting!

I realize that I can change a font for each epub using css, etc., but the point 
is that an epub should not be required to specify fonts, so that they are be 
displayed on the target device in the font of the user's choice.  So changing 
each epub's css files to my font choices isn't really the proper fix.

Thank you!

Original issue reported on code.google.com by laura1...@gmail.com on 25 Aug 2011 at 1:08

GoogleCodeExporter commented 9 years ago 
If you want the text in Book View to be serif, you need to specify font-family: 
serif in an appropriate place in the css. In the absence of a font-family 
definition, the reader is free to use whatever font it has specified as the 
default. Sigil is merely following the standard here.

It seems that what you're really asking for is an option to change the default 
display fonts. At some point we're going to add a options panel and could 
implement it there, although this is a long-term goal.

Original comment by CajK...@gmail.com on 25 Aug 2011 at 11:07

GoogleCodeExporter commented 9 years ago 
Thanks for the response!  I am disappointed that giving a display font option 
to the user is low-priority.  The reason I posted is that I do not understand 
why some of the displayed fonts are my (system) fonts but some are not.  It 
just seems strange to me that Sigil would impose its own default font in the 
reader but not in other places that would be less important to the user.

All that said, this is a terrific program and it has helped me clean up several 
epubs.  Thank you for the great work!

Original comment by laura1...@gmail.com on 25 Aug 2011 at 11:22

GoogleCodeExporter commented 9 years ago 
As I said, you *already have* the option to control the font that is displayed 
in the css, and this will control the display of the book on any compliant 
reader. Changing the default font in the renderer is a purely cosmetic issue 
that won't affect how your book will look in different readers, which is why 
it's low priority.

The point is, an ePub *should* be required to specify fonts, at least at a 
generic level (serif, sans-serif etc). Any changes made at a local level won't 
affect the way the book looks on different readers and may just confuse people.

Original comment by CajK...@gmail.com on 26 Aug 2011 at 6:03

GoogleCodeExporter commented 9 years ago 
I'm sorry to argue, but I have a Nook, and it doesn't work that way, and it is 
where I got my apparently mistaken assumptions and expectations.  The Nook has 
about six installed fonts, and you choose one, and that's the one it uses on 
all ePubs.  And I prefer that because (in case you missed this :) )  I HATE 
sans-serif fonts and if I was forced to read books in them it would seriously 
reduce the pleasure quotient and I would use the device less than I do.  As for 
confusion, I WAS confused (and still don't quite understand the rationale for 
Sigil forcing its choice on me instead of taking its cue from my system fonts, 
or asking me), or I wouldn't be bothering you!

But what this boils down to is that if I want to see the ePubs in my chosen 
fonts, I have to either wait for a program option which is a low priority, or 
learn css and edit all my hundreds of ePubs.   (And BTW since I do not know css 
and since Sigil doesn't provide a generic main style sheet in the Styles folder 
to use as a template, this is non-trivial.)   I understand that now-- and I do 
appreciate the clear answer and your responsiveness to my concerns.  Thank you 
for all your hard work!

Original comment by laura1...@gmail.com on 26 Aug 2011 at 7:11

GoogleCodeExporter commented 9 years ago 
Attaching a patch for this from GaryJ.

This patch as two issues. One it's not setting the menu action in the UI file 
where it needs to be. ExtendUI is only used for things that must be set 
programmatically. The other issue is that this really needs to be set in a 
preferences dialog and not added to the menu.

I'm setting this to blocked on issue 206 which is for implementing a preference 
dialog. A cleaned up patch won't be merged until 206 is finished.

Original comment by john@nachtimwald.com on 31 Aug 2011 at 12:59

Attachments:

GoogleCodeExporter commented 9 years ago 
Thank you so much for the patch!  I look forward to the next release, since I'm 
out of my depth when it comes to applying/compiling code.  It looks great 
though!  Thanks again!

Original comment by laura1...@gmail.com on 5 Sep 2011 at 9:33

GoogleCodeExporter commented 9 years ago

Original comment by daveheil...@gmail.com on 24 Aug 2012 at 6:17