search

Rainie3535 / sigil

Automatically exported from code.google.com/p/sigil
GNU General Public License v3.0
0 stars 0 forks source link

Split does not update file references in TOC #999

Closed GoogleCodeExporter closed 9 years ago

GoogleCodeExporter commented 9 years ago 
I hit F6 and split my book, then Sigil can't find anymore in wich file my IDs 
are. In the toc.ncx it just refers to Text\split.htm#myID (it should be 
Text\split_XXXX.htm#myID).

I'm using Sigil 0.4.1 on a PC with Windows 7 32bit.

Original issue reported on code.google.com by zsb...@gmail.com on 1 Sep 2011 at 3:00

GoogleCodeExporter commented 9 years ago 
An manual build of the Table of Contents will sort this for this book.

Should really be automatic after an F6/Split.

Original comment by shaun.voysey@outlook.com on 1 Sep 2011 at 4:33

GoogleCodeExporter commented 9 years ago 
Yes, heading IDs aren't in the list of tracked resources modified automatically 
after a split or file rename. All you need to do is press the 'Generate ToC' 
button again for it to find them. We can change this in 0.5.0

Original comment by CajK...@gmail.com on 3 Sep 2011 at 7:20

GoogleCodeExporter commented 9 years ago

Original comment by CajK...@gmail.com on 18 Sep 2011 at 5:34

GoogleCodeExporter commented 9 years ago 
Issue 1067 has been merged into this issue.

Original comment by john@nachtimwald.com on 14 Oct 2011 at 11:07

GoogleCodeExporter commented 9 years ago

Original comment by meme90...@gmail.com on 24 Jan 2012 at 8:45

GoogleCodeExporter commented 9 years ago

Original comment by meme90...@gmail.com on 23 Mar 2012 at 5:54

GoogleCodeExporter commented 9 years ago 
Patch attached.

Original comment by meme90...@gmail.com on 29 Mar 2012 at 4:37

Attachments:

GoogleCodeExporter commented 9 years ago 
Updated patch merging with latest source.

Original comment by meme90...@gmail.com on 11 Apr 2012 at 7:13

Attachments:

GoogleCodeExporter commented 9 years ago 
"Generate TOC" will not fix the issue here since exporting from Indesign did 
not produce H1 tags etc. ie. there are no "TOC Entries" in the "Heading 
Selector".

Original comment by e107...@gmail.com on 17 Apr 2012 at 5:32

GoogleCodeExporter commented 9 years ago 
That's not the reported issue.  The reported issue is that splitting does not 
update the TOC, which is corrected by this patch.

If Indesign is not labelling headers with heading tags, then that's not Sigil's 
issue.  You can use Sigil to add heading tags or manually create the TOC.

Original comment by meme90...@gmail.com on 17 Apr 2012 at 7:00

GoogleCodeExporter commented 9 years ago 
Indeed. I'm thankful it is corrected so that splits while editing 
Indesign-exported ePubs can be done without corrupting the TOC. Am I right to 
assume that this patch will be included in 0.6.0? And I guess the patch is only 
for the source, not the current release.. correct?

Original comment by e107...@gmail.com on 17 Apr 2012 at 9:17

GoogleCodeExporter commented 9 years ago 
The patch is for source only and still has to be reviewed before being included 
in the official source.  This is meant for the 0.6.0 release but there may be 
reasons it doesn't make it.

Original comment by meme90...@gmail.com on 17 Apr 2012 at 11:21

GoogleCodeExporter commented 9 years ago 
A few issues with this patch.

There are two calls to AnchorUpdates::UpdateExternalAnchors in the 
BookManipulation/Book.cpp. Both should have NCX updates.

The patch in it's current state only updates the NCX when split on chapter 
breaks is used. It doesn't do anything for split in BV or CV.

Original comment by john@nachtimwald.com on 18 Apr 2012 at 1:27

GoogleCodeExporter commented 9 years ago 
New patch attached with extra call to TOC updated in B*/Book.  Also attached 
sample file.

This appears to work for both Edit->Split Chapter(Ctrl-Return) and Edit->Split 
At Chapter Breaks(F6) on chapter breaks, in BV and CV.

Its not clear how split in BV/CV is any different?

Note 1354 is a semi-related split issue but not TOC related.

Original comment by meme90...@gmail.com on 18 Apr 2012 at 7:40

Attachments:

GoogleCodeExporter commented 9 years ago

Original comment by john@nachtimwald.com on 20 Apr 2012 at 1:50

GoogleCodeExporter commented 9 years ago

Original comment by daveheil...@gmail.com on 19 May 2012 at 3:20