RainwayApp / bug-tracker

Report all issues found with Rainway here, or make suggestions for new features. 🐜
https://rainway.io/
27 stars 3 forks source link

Cannot download the Rainway client in firefox #292

Closed Sixmorphugus closed 5 years ago

Sixmorphugus commented 5 years ago

Cannot download the Rainway client in firefox

I do not know if this worked in a previous version

If you navigate to the Rainway website in Firefox, Waterfox, or some other version of the Firefox browser, the wrong version (v0.0.0000) of Rainway is shown and you cannot start downloaded rainway, even with the try again button on the download page.

Steps

What happens

See Steps.

What is expected

I expected what happens in Chrome to happen:

Host

Browser

N/A

Logs

N/A

andrewmd5 commented 5 years ago

Can you load https://releases.rainway.com/Installer_current.json in your browser?

Sixmorphugus commented 5 years ago

image

I get this in Waterfox.

agentd00nut commented 5 years ago

This is caused by that json file not being encoded "properly".

JSON files are supposed to be encoded as UTF-8.

Our file is being encoded as UTF16LE which places a byte order marker (FF FE) bytes at the front of the file.

Firefox is seeing these bytes and isn't properly ignoring them the way that chrome and other browsers apparently do.

I converted the encoding of the file and firefox was able to read it fine, but moving forward whoever generates that file ( i don't ) needs to make sure the encoding is UTF-8.