search

RainwayApp / bug-tracker

Report all issues found with Rainway here, or make suggestions for new features. 🐜
https://rainway.io/
27 stars 3 forks source link

Rainway Dashboard notification icon shows (Offline) when online #356

Open riverar opened 4 years ago

riverar commented 4 years ago

Rainway app version 1.0.14.0 Windows 10 1903 18362.1

Repro steps:

  1. Configure Rainway to not use uPnP.
  2. Start Rainway, wait for Ready to Host to appear
  3. Hover over notification icon and see (Offline)

image

andrewmd5 commented 4 years ago

Hey @riverar thanks for this bug report! It will be fixed in our next patch.

riverar commented 4 years ago

Still seeing this in 1.0.15.0. cc: @Codeusa

andrewmd5 commented 4 years ago

Thanks for note @riverar. I just double checked and I am unable to reproduce. Looking at the code, this text is set by our internet connection checks which pings 8.8.8.8, 1.1.1.1, and 223.5.5.5. If all three of those pings fail, it will set the text to Offline. I did find an error in there that might cause a false-positive, but I don't think its tied directly to UPNP. I've written a patch for that one issue which should go live Monday.

We also do a hard check for NetworkInterface.GetIsNetworkAvailable() and if that returns false, that could also be a cause.

If you enable UPNP does it say Online again?

riverar commented 4 years ago

@Codeusa Ahhh, I have ICMP filtered on my Rainway boxes.

Since Rainway is anchored to Windows 10, maybe one enhancement (low priority) would be to tap into WinRT's NetworkInformation.GetInternetConnectionProfile() / GetNetworkConnectivityLevel().

That returns ConnectionProfile::InternetAccess on my boxes right now.

andrewmd5 commented 4 years ago

Wasn't aware of these, I will implement them since we already use NetworkStatusChanged to trigger the pings.

andrewmd5 commented 4 years ago

Just an update that this particular change didn't make it in, but it's staged for 1.0.17.