search

RainwayApp / node-clangffi

Generate Typescript FFI bindings for C/C++ libraries using libclang and ffi-napi.
MIT License
7 stars 1 forks source link

faster CI integration tests #24

Closed bengreenier closed 2 years ago

bengreenier commented 2 years ago

The current CI "integration" test is to walk libclang v13 and ensure we find the same types in it each time. This is good for ensuring we can always regenerate libclang-bindings using libclang-bindings but probably doesn't need to happen for validation of a PR, given it takes upwards of 15m in CI.

We should instead introduce a smaller integration test(s) that give us similar confidence, but execute much more quickly. Further, rather then just removing the existing one, we could consider instead running that only on check-in to main (after PR has been merged) for added confidence, but without slowing down the inner loop.

lynn commented 2 years ago

Fixed in #50: there's a smaller snapshot test for TypeScript codegen now.