search

Raiper34 / m3u-parser-generator

Library to parse and generate m3u or m3u8 IPTV playlist files
https://m3u-parser-generator.netlify.app
MIT License
24 stars 11 forks source link

fix: ignore empty attributes string #4

Closed akoshman closed 1 year ago

akoshman commented 1 year ago

Hi, there is a fix for lines without attributes specified. And a small improvement to ignore blank lines

Raiper34 commented 1 year ago

Hello friend, thank you for your PR, I see, you added some new branches and statements, but they are not unit tested, can you add unit tests, please? You can check coverage when you run npm run test and then you can see it in coverage/lcov-report/index.ts file in your browser. Can you cover m3u-parser.ts to keep 100% coverage, please? After that I will merge it and release ;) Best!

ducktrshessami commented 1 year ago

I started writing tests to PR to this fork, but noticed the above. Since the author of this PR seems to be inactive, how should I proceed?

akoshman commented 1 year ago

hello @ducktrshessami I'm not really into JS development and can't write these tests atm, so please go ahead and improve these PR any way you want

Raiper34 commented 1 year ago

I started writing tests to PR to this fork, but noticed the above. Since the author of this PR seems to be inactive, how should I proceed?

Any progress with that? Do you need help from my side? I would add an improperly formatted attribute unit test if we want to keep this change.

ducktrshessami commented 1 year ago

Forgot to mention for link akoshman/m3u-parser-generator#1. I figured it could be left in, but should error instead of inserting an undefined value. A test was written as well. Just waiting on @akoshman.

akoshman commented 1 year ago

Hello @ducktrshessami You can just take my commit and make a new pull request.

ducktrshessami commented 1 year ago

Uh alright

Raiper34 commented 1 year ago

Finished in #5