search

Raistlfiren / garmin-csv-plan

A quick n' dirty way of "automating" training plans into Garmin Connect.
https://raistlfiren.github.io/garmin-csv-plan/
36 stars 6 forks source link

Parser.php does not recognize repeating runs #12

Closed f4hla closed 3 years ago

f4hla commented 3 years ago

Hello as can be seen in ultra-80k....csv test file, we could define a run and then reuse by just entering the name of it. However, in this case it fails with

In Parser.php line 98:
Call to a member function getName() on null

Found that this is because we always try to build a new workout (line 189) based on type that is not repeated in case of same exercise....we need to create a "memory" thanks :)

pygoubet commented 3 years ago

Hi The PR #14 provides the ability to import the complete plan 'ultra-80k-runnersworld.csv'

f4hla commented 3 years ago

Tested ok 👍 👌 Good Job!

Raistlfiren commented 3 years ago

I have updated the code to now include support for nested repeaters.