RaitaroH / KissAnime-DeepDark

Watch anime in a bright room with a dark theme. May the dark be kinder on thine eyes. (KissAnime dark theme)
GNU General Public License v3.0
4 stars 1 forks source link

Issue while using with Ublock Origin #1

Closed Adyel closed 6 years ago

Adyel commented 6 years ago

Hey, I encountered this issue today. When I use Ublock Origin (a content blocker extension) with this style some ads slipped through ( #adsIfrme8 and #adsIfrme10 ). Why is this happening can you tell?

screenshot-20

RaitaroH commented 6 years ago

:man_facepalming: ah well, kissanime and ublock have never been friends. I honestly gave up on trying to fix those issues when they come up because I refresh the page and they are gone.... no idea why. But I will add those elements to the code if it makes you feel better.

RaitaroH commented 6 years ago

For instance I don't even have those...

Adyel commented 6 years ago

I turned off the cosmetic filter for Kissanime in Ublock Origin. It shows properly now.

RaitaroH commented 6 years ago

Yeah.... Here is the code I already hide those:

    /*Ads*/
    #divFloatLeft, #tab-trending > div:nth-child(1), #divAds2, #divAds1, #divAds, #divFloatRight, #adsIfrme6, div.divCloseBut, #adsIfrme0, #adsIfrme1, #adsIfrme2, #adsIfrme3, #adsIfrme4, #adsIfrme5, #adsIfrme6, #adsIfrme7, #adsIfrme8, #adsIfrme10, #videoAd, .videoAdClose, [id*="BB_S"]
    {
        display: none !important;
    }
Adyel commented 6 years ago

It seems like it more of Ublock issue. Thanks for quick response :)

RaitaroH commented 6 years ago

https://github.com/RaitaroH/KissAnime-DeepDark/commit/4e20a430ebca34684dbfdbb2f5df641adbd830ce This is the best I can do. Sorry.

Adyel commented 6 years ago

Thanks man

RaitaroH commented 6 years ago

@Adyel Btw, you might want to crop your avatar a bit better. It quite shows on a dark theme. Don't take it the wrong way :P

Not crop... render (delete the white outline)