RaitaroH / YouTube-DeepDark

Videos should only be watched in the dark. May the dark be kinder on thine eyes. (YouTube dark theme)
GNU General Public License v3.0
221 stars 52 forks source link

YouTube new update: Ambient mode #77

Closed BobbyWibowo closed 2 years ago

BobbyWibowo commented 2 years ago

Hi there, it seems we're getting more and more "material-ish" updates to YouTube, and one of the recent changes seem to be dynamic backlight thingy

https://user-images.githubusercontent.com/9364930/199154708-cce99ff8-99a2-4882-95f3-ea10417f5ac4.mp4

(ignore the fps, it was some recording setting issue)

Unfortunately, some sections currently have fixed backgrounds with the userstyle active:

image

BobbyWibowo commented 2 years ago

If it hasn't shown for you, it seems it's a new option on the player, called "Ambient mode"

image

I bandaged mine with the following, but I'm not familiar enough with the rest of the styling to say if that won't cause any other issues:

ytd-watch-flexy[cinematics-enabled] [class*="ytd-watch-flexy"] {
    background-color: unset !important;
}

cinematics-enabled attribute will still be there even after manually toggling ambient mode to off from the player's settings So I guess it can only be used as a simple indicator, as to whether the player already has the feature or not, regardless of the actual enabled state

Anyways, good enough for me as a personal bandage 🏃‍♂️

RaitaroH commented 2 years ago

As I am testing youtube in light mode (to spot any issues) I didn't have this. It seems it only shows up if after I enable dark theme in youtube.

Anyhow, this is better on my end:

    #cinematics.ytd-watch-flexy
    {
        display: none !important;
    }

I am not sure if I should just remove this entirely... or add a toggle for those who would want to keep it. Any thoughts? It actually looks awful and would need quite a bit of work to fix. Will disable.

RaitaroH commented 2 years ago

@BobbyWibowo check out the latest version and see if anything else is broken. I have also fixed sub,join and like buttons. Also cookie consent page.

BobbyWibowo commented 2 years ago

I am not sure if I should just remove this entirely... or add a toggle for those who would want to keep it. Any thoughts?

I personally would want to keep it, considering it's already toggle-able by users from the player settings either way But yeah that said I can't really speak for everybody about that

It actually looks awful and would need quite a bit of work to fix. Will disable.

Correct I forgot to mention that it also required me enforcing --main-background variable to #0f0f0f, the plain background the ambient mode seemingly expects the YouTube page to be at, for it to blend perfectly I have no idea if it's even possible to change that, but it wasn't too different to stock DeepDark's background for me to be bothered about, so I settled with just changing it, haha

On that note, for reasons that I wasn't clear about, it seems the following custom color settings did not appear to work on my end?

Screenshot ![image](https://i.fiery.me/75GN.png)

Had to settle with just adding a new custom style instead

I have also fixed sub,join and like buttons. Also cookie consent page.

Appreciate the updates! I can't find anything else going funky due to the YouTube updates thus far But I don't usually stray too far from video pages and all that

RaitaroH commented 2 years ago

On that note, for reasons that I wasn't clear about, it seems the following custom color settings did not appear to work on my end?

You have to pick "Custom" preset first, then change those colors. Perhaps a bit confusing, but that is how it is implemented.

In regards to ambient, I will just keep it disabled.

Thank you for opening this issue and providing information.