search

RaitaroH / YouTube-DeepDark

Videos should only be watched in the dark. May the dark be kinder on thine eyes. (YouTube dark theme)
GNU General Public License v3.0
221 stars 52 forks source link

Mobile support #88

Closed Sneffel closed 1 year ago

Sneffel commented 1 year ago

Hi. On my phone most colours aren't affected. Could you implement smaller screen sizes?

RaitaroH commented 1 year ago

I have no intention on porting this on mobile. Media queries (for size) are done by youtube, as such the theme technically works on smaller screen sizes (in the inspector) Addons only work on some browsers as well.

Sneffel commented 1 year ago

the theme technically works on smaller screen sizes (in the inspector)

No, it does not. Have you checked m.youtube.com with a phone user agent? Screen Shot 2023-01-10 at 07 36 35 It looks kind bad ngl

Addons only work on some browsers as well.

I got stylus working on my phone, so

RaitaroH commented 1 year ago

No, it does not. Have you checked m.youtube.com with a phone user agent?

As I mentioned, in the inspector.

Media queries (for size) are done by youtube, as such the theme technically works on smaller screen sizes (in the inspector)

image

I was not aware of m.youtube.com. Nevertheless, m.youtube.com on non-mobile redirects to https://www.youtube.com/?app=desktop, making any development on this more difficult.

It looks kind bad ngl

Youtube doesn't care about the website. They push people onto the app. If there are any conflicts between the desktop theme and mobile page, you can disable the theme.

I don't use the website; I don't think most people do. If anybody, including you, makes a PR for this, I will review it for merging. But, I will not provide support for the mobile site.

Sneffel commented 1 year ago

I was not aware of m.youtube.com. Nevertheless, m.youtube.com on non-mobile redirects to https://www.youtube.com/?app=desktop, making any development on this more difficult.

That's why you paste the user agent in the top