search

RajLabMSSM / echofinemap

echoverse module: Statistical and functional fine-mapping functions.
2 stars 1 forks source link

Make sure polyfun submodule gets installed #2

Open bschilder opened 2 years ago

bschilder commented 2 years ago

The polyfun repo is not getting included in "inst/tools" when installing echofinemap. This is because the submodule is being interpreted as an empty folder by R: https://stackoverflow.com/questions/50474445/how-could-i-release-an-r-package-on-github-using-github-submodules

Suggested solution with packrat: https://blog.methodsconsultants.com/posts/using-packrat-with-git-submodules/

Discussion on devtools: https://github.com/r-lib/devtools/issues/1163 https://github.com/r-lib/devtools/pull/1222

git2r package: https://github.com/ropensci/git2r

This function seems promising: https://github.com/r-lib/devtools/pull/751#issuecomment-215540807

bschilder commented 2 years ago

Intermediate solution: when users request to use PolyFun for the first time, they will have the option of re-installing echofinemap to add PolyFun. Not ideal, but it does work pretty consistently.